Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(module:version): add secondary entries #3807

Merged
merged 3 commits into from
Jul 18, 2019
Merged

refactor(module:version): add secondary entries #3807

merged 3 commits into from
Jul 18, 2019

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Jul 17, 2019 •
edited
Loading

Deploy preview for ng-zorro-master ready!

Built with commit 17e11c0

https://deploy-preview-3807--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Jul 17, 2019 •
edited
Loading

Codecov Report

Merging #3807 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3807      +/-   ##
=========================================
+ Coverage    95.4%   95.4%   +<.01%     
=========================================
  Files         709     711       +2     
  Lines       14587   14593       +6     
  Branches     1924    1924              
=========================================
+ Hits        13917   13923       +6     
  Misses        243     243              
  Partials      427     427
Impacted Files Coverage Δ
components/ng-zorro-antd.module.ts 98.44% <100%> (-0.03%) ⬇️
components/version/public-api.ts 100% <100%> (ø)
components/version/version.ts 100% <100%> (ø)
components/version/index.ts 100% <100%> (ø)
...omponents/date-picker/abstract-picker.component.ts 100% <0%> (ø) ⬆️
components/core/tree/nz-tree-base.ts 97.05% <0%> (+0.08%) ⬆️
components/carousel/strategies/base-strategy.ts 96.15% <0%> (+0.15%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0677540...17e11c0. Read the comment docs.

wzhudev
wzhudev approved these changes Jul 17, 2019
View reviewed changes
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vthinkxie
vthinkxie reviewed Jul 17, 2019
View reviewed changes
docs/universal.en-US.md Outdated Show resolved Hide resolved
@hsuanxyz @vthinkxie
docs(universal): fix docs
17e11c0 
Co-Authored-By: vthinkxie <vthinkxie@users.noreply.github.com>
vthinkxie
vthinkxie approved these changes Jul 18, 2019
View reviewed changes
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit ef9a9e3 into NG-ZORRO:master Jul 18, 2019
@lppedd lppedd mentioned this pull request Jul 18, 2019
Closed
3 tasks
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
@hsuanxyz @Ricbet
refactor(module:version): add secondary entries (NG-ZORRO#3807)
53993ba 
* refactor(module:version): add secondary entries

* chore: fix lint

* docs(universal): fix docs
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@hsuanxyz @vthinkxie
refactor(module:version): add secondary entries (NG-ZORRO#3807)
03884c4 
* refactor(module:version): add secondary entries

* chore: fix lint

* docs(universal): fix docs
@hsuanxyz hsuanxyz deleted the version branch August 5, 2020 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzhudev wzhudev wzhudev approved these changes

@vthinkxie vthinkxie vthinkxie approved these changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsuanxyz @vthinkxie @wzhudev